Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: More Minor API Bugfixes and Updates #409

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Core: More Minor API Bugfixes and Updates #409

merged 4 commits into from
Jun 20, 2024

Conversation

abhiTronix
Copy link
Owner

Brief Description

This PR encompasses a series of enhancements and bug fixes across multiple components of the project, aimed at improving functionality, optimizing performance, and enhancing user experience.

Requirements / Checklist

Related Issue

#394
#403

Context

This PR is part of ongoing efforts to improve the overall functionality, performance, and usability of the project, addressing both user-reported issues and opportunities for internal optimization.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- 🔊 Updated `no_warnings` parameter in `CamGear` to be `False` when logging is enabled and `True` otherwise.
#403)

- ⚡️ Updated `homepage`, `not_found`, and `server_error` methods to include more detailed JSON error messages.
- 🥅 Added specific error and message prefixes to improve clarity.
📝 Docs: Fixed minor code highlighting
@abhiTronix abhiTronix added BUG 🐛 Vidgear api's error, flaw or fault WORK IN PROGRESS 🚧 currently been worked on. DOCS 📜 Issue/PR is related to vidgear docs. PENDING TESTS 🧪 Waiting for CI tests to complete successfully. labels Jun 20, 2024
@abhiTronix abhiTronix added this to the v0.3.3 milestone Jun 20, 2024
@abhiTronix abhiTronix self-assigned this Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (e533553) to head (c90183a).

Additional details and impacted files
@@             Coverage Diff             @@
##           testing     #409      +/-   ##
===========================================
+ Coverage    93.40%   93.57%   +0.16%     
===========================================
  Files           15       15              
  Lines         3080     3080              
===========================================
+ Hits          2877     2882       +5     
+ Misses         203      198       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhiTronix abhiTronix merged commit c456574 into testing Jun 20, 2024
12 checks passed
@abhiTronix abhiTronix deleted the development branch June 20, 2024 14:40
@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. PENDING TESTS 🧪 Waiting for CI tests to complete successfully. labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG 🐛 Vidgear api's error, flaw or fault DOCS 📜 Issue/PR is related to vidgear docs. SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: WebGear throws error 500: context must include a "request" key [Bug]: Logging issue with yt-dlp
1 participant