-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore issue if it is a Pull request #73
base: master
Are you sure you want to change the base?
Ignore issue if it is a Pull request #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 86.70% 86.73% +0.03%
==========================================
Files 24 24
Lines 391 392 +1
Branches 80 80
==========================================
+ Hits 339 340 +1
Misses 47 47
Partials 5 5
Continue to review full report at Codecov.
|
Not sure if a test for this is needed. Let me know if I should add a test and how best add it (new test or adjust existing test). |
@abhijeetps Can this PR get reviewed please? |
@Glennmen , thank you. |
@abhijeetps No problem! Glad to see that there is stil some activity in this useful project. |
@abhijeetps Have you been able to test this PR yet? |
According to the Github API docs the Issues endpoint also returns Pull requests: https://developer.github.com/v3/issues/?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc#list-issues
This PR adds an extra filter that removes PR's from the list of Issues. More info can be found in the issue I made #72
Fixes #72