add mcs serviceexports and serviceimports #11
Conversation
|
agreed manual installation is not cool. i wonder what others do? perhaps an operator or some other tooling which must be installing these CRDs? |
| @@ -0,0 +1,133 @@ | |||
| # Copyright 2020 The Kubernetes Authors. | |||
There was a problem hiding this comment.
i don't think we put copyright header in yaml files.. at least don't see that in rest of antrea build/yamls
There was a problem hiding this comment.
ok, let me remove it.
|
@abhiraut I think if there is an operator, it should be done by operator to install these CRDs, submariner install them in operator. do you think we should introduce an operator now or leave it in current folder for demo? |
Signed-off-by: Lan Luo <luola@vmware.com>
luolanzone
force-pushed
the
add-mcs-crds
branch
from
a769e44
to
ac6e2af
Compare
|
i think we keep it as is now.. but would like to explore the operator option in future.. |
| type: string | ||
| port: | ||
| description: The port that will be exposed by this service. | ||
| format: int32 | ||
| type: integer | ||
| protocol: | ||
| default: TCP | ||
| description: The IP protocol for this port. Supports | ||
| "TCP", "UDP", and "SCTP". Default is TCP. | ||
| description: The IP protocol for this port. Supports "TCP", "UDP", and "SCTP". Default is TCP. |
There was a problem hiding this comment.
some of these changes look unrelated; probably because we didn't run make manifest in the past?
There was a problem hiding this comment.
yes, I think I forgot to run make manifest last time. new labels are added now. the line format are new but it's controlled by generator, no change introduced in configuration.
Signed-off-by: Lan Luo <luola@vmware.com>
I think we need serviceexports and serviceimports crds from mcs, otherwise, user have to install it manually via k8s mcs for antrea multi-cluster features.
Signed-off-by: Lan Luo luola@vmware.com