fix common area bug #25
Conversation
Signed-off-by: Lan Luo <luola@vmware.com>
|
@abhiraut I found a few bugs during common area integration, so I submit this PR in case you need this fix to work on integration for importer. |
| @@ -206,18 +206,16 @@ func (r *ClusterSetReconciler) updateMultiClusterSetOnMemberCluster(clusterSet * | |||
| if r.RemoteClusterManager == nil { | |||
| r.RemoteClusterManager = internal.NewRemoteClusterManager(r.clusterSetID, r.Log, r.clusterID) | |||
| go func() { | |||
There was a problem hiding this comment.
@aravindakidambi I am wondering why we need a go routine here? since I noticed that there will be an inconsistent issue if r.RemoteClusterManager is initialized and used in other controller like serviceexporter controller, but after a while, it might become nil when start() failed. I suppose we can start it without go routine?
thanks! could you add the fix description in the PR :) |
|
@abhiraut sure, I have updated the description of the issue. |
|
@aravindakidambi could you take one look, so we can merge this ASAP |
|
@luolanzone could you rebase and we will merge after that |
|
@abhiraut I think we can close this one since this fix is already in PR22 which you have merged. |
r.RemoteClusterManagerSigned-off-by: Lan Luo luola@vmware.com