support negative values #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsonck92
reviewed
Jun 8, 2022
Comment on lines
+418
to
+423
| switch d.(type) { | ||
| case uint64: | ||
| return d.(uint64) + 1 | ||
| case int64: | ||
| return d.(int64) + 1 | ||
| } |
There was a problem hiding this comment.
Just noting that type assertion switch cases can do the conversion for you:
Suggested change
| switch d.(type) { | |
| case uint64: | |
| return d.(uint64) + 1 | |
| case int64: | |
| return d.(int64) + 1 | |
| } | |
| switch v := d.(type) { | |
| case uint64: | |
| return v + 1 | |
| case int64: | |
| return v + 1 | |
| } |
There was a problem hiding this comment.
Very true, my mind blanked when I was writing it this morning. I'll probably lump that change in when I bump dependencies
There was a problem hiding this comment.
Heh, well, I do like the elegant solution, making sure the signedness of the underlying type get used internally so any hardcoded values will have to match.
There was a problem hiding this comment.
Yeah, had about 3 or 4 iterations before I landed on this one. Definitely felt like the right level of safety and flexibility. Thanks for double checking my work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for negative values (also fix max uint64 value offset).
Fixes #104