Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote handling #168

Closed
wants to merge 4 commits into from
Closed

Add quote handling #168

wants to merge 4 commits into from

Conversation

abice
Copy link
Owner

@abice abice commented Jan 29, 2023

This builds on #165 and adds quote handling.

@coveralls
Copy link

Coverage Status

Coverage: 93.027% (+0.3%) from 92.679% when pulling b6063a6 on abice/addQuotes into 1e5efaa on master.

@abice
Copy link
Owner Author

abice commented Jan 29, 2023

@ThinkChaos

I'm not the best at having git do things I want it to do, so if you'd like credit for the PR being done (rather than just the commits, which after rebasing, show me as partial contributor), please go ahead and update your branch with quotation handling and I'll merge it.

This is how I chose to handle quotes, so feel free to take it and run. I'll leave this PR open for a week, and if I don't hear back from you, I'll go ahead and merge this one.

Thanks again for the initial implementation!

@abice
Copy link
Owner Author

abice commented Jan 30, 2023

Closed in favor of #165

@abice abice closed this Jan 30, 2023
@abice abice deleted the abice/addQuotes branch January 30, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants