Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for sqlite < 3.20.0 + fix app crash when no fts5 or wrong language #8

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

and-se
Copy link
Contributor

@and-se and-se commented Feb 24, 2021

Hello! Thank you for this library! I use it in my python application to handle non-english texts.

This PR adds some features:

  • support for sqlite < 3.20.0 (I was surprised that ubuntu 16.04 has an older version of sqlite on my vds)
  • fix app crash when no fts5
  • fix app crash when trying to use an unknown language in snowball.
    For example CREATE VIRTUAL TABLE t USING fts5(text, tokenize='snowball bad-language') - this produced app crash due to double free.

Tested on 3.13.0 - works. Tested on 3.8.2 - not works because fts5 extension appeared in 3.9.0
It's good for a very old sqlite (3.8), where is no fts5 at all
…anguage.

For example "CREATE VIRTUAL TABLE t USING fts5(text, tokenize='snowball wrong-language');
@abiliojr
Copy link
Owner

abiliojr commented Apr 14, 2021

Thanks for your contribution!

@abiliojr abiliojr merged commit 866d692 into abiliojr:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants