-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored build system for scipy2014_boost_python_workshop_student_material #4
Comments
Excellent, thanks! Do you mind if I just merge that directly into my On Mon, Jul 7, 2014 at 3:59 PM, Jean-Christophe Fillion-Robin <
|
Also, what's the best introduction (tutorial, documentation, or whatever) On Tue, Jul 8, 2014 at 6:25 AM, Austin Bingham austin.bingham@gmail.com
|
Good morning, // ---------------------------------
Please consider integrating the following commit, I consolidated the history and fix the license header. See jcfr/scipy2014_boost_python_workshop_student_material@605e9fa The commit is now associated with a branch named "add-cmakelists" See https://github.com/jcfr/scipy2014_boost_python_workshop_student_material/tree/add-cmakelists I would also recommend that you associate a license with your work, I currently associated "Apache 2" with the CMakeLists.txt. I also have no problem switching to MIT license if you would prefer. You could for example add file like this one at the top level [1] [1] https://github.com/davidsansome/python-cmake-buildsystem/blob/master/LICENSE_Apache_20 .. and update the README as [2] [2] https://github.com/davidsansome/python-cmake-buildsystem#licenses Finally, regarding the great presentation / notebook [3] you created, I would suggest you also associate a license that would protect your creative works, you could for example add a Creative Commons by Attribution 4.0 License as it is done in [4] [3] https://github.com/abingham/boost_python_tutorial // ---------------------------------
Reading the following page will give you a good introduction: http://www.cmake.org/cmake/help/git-master/manual/cmake-buildsystem.7.html Then, mailing list and wikis will provide you with some useful information. If you have specific questions, subscribing to the CMake user can be helpful. |
In the instructions you have:
github.com/jcfr/scipy2014_boost_python_workshop_student_material.git Is that last line correct? I seems like it should be "cmake On Tue, Jul 8, 2014 at 8:24 AM, Jean-Christophe Fillion-Robin <
|
On Tue, Jul 8, 2014 at 11:54 AM, abingham notifications@github.com wrote:
Good catch. I just pushed an update on top of "add-cmakelists" topic: jcfr/scipy2014_boost_python_workshop_student_material@dc6d689 Before integrating my topic .. you could add an other commit on top of it Hth +1 919 869 8849 |
Since the changes were small and simple I just manually copied your changes On Tue, Jul 8, 2014 at 11:50 AM, Jean-Christophe Fillion-Robin <
|
Hi,
For reference, I just pushed on github a patch allowing to easily build the complete set of exercises and answer associated with the workshop.
The README has also been updated. See here
See jcfr/scipy2014_boost_python_workshop_student_material@bec2acc...master
The text was updated successfully, but these errors were encountered: