Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to ack requests and to check errors on WaitFor. Flush is als… #2

Merged
merged 1 commit into from
Apr 23, 2016

Conversation

traetox
Copy link

@traetox traetox commented Apr 23, 2016

…o issued

I updated to check the errors on WaitFor and to Ack request on completion. Without Acking the map that tracks the ACKs will grow indefinitely.

Testing shows a significantly lower blocking rate. I am showing throughput closer to 280Mbit/s on my i5-4690k and a cheapo SSD. No errors on testing.

@abligh
Copy link
Owner

abligh commented Apr 23, 2016

Thanks. I'm taking it the lack of Ack() was causing the memory leak?

I'll merge this. It still won't support flush, because it the backend doesn't supply the flush flag (and it should do the same with FUA like the file driver). But that isn't much of an issue as my understanding is no file systems support AIO flush and there's no way to tell if one does in the future. So I'll put some out-of-band support for that in (aka a configuration flag).

@abligh abligh merged commit d38260f into abligh:master Apr 23, 2016
@abligh
Copy link
Owner

abligh commented Apr 23, 2016

Nope. This doesn't prevent the test being killed here :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants