Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/1280 unique test channel names #1282

Merged
merged 26 commits into from
Mar 12, 2022
Merged

Fix/1280 unique test channel names #1282

merged 26 commits into from
Mar 12, 2022

Conversation

maratal
Copy link
Collaborator

@maratal maratal commented Feb 7, 2022 •
edited
Loading

Closes #1280

@maratal
Function to provide a unique test channel name
ac72e54
@maratal
Replaced RestClientChannelTests global channel variable with loca…
c824a29 
…l one with the unique name
@maratal
Replaced RestClientChannelTests global channelName variable with …
cd6b4a9 
…the unique name for message size tests
@maratal
Added channelName parameter to RestClientChannelTests `testSuppor…
a2641ae 
…tsAESEncryptionWithKeyLength` function
@maratal
Replaced static channel names with the unique ones in `RestClientChan…
416d28f 
…nelTests`
@maratal
Replaced static channel names with the unique ones in RestClientTests
c2f342d
@maratal
Replaced static channel names with the unique ones in `RealtimeClient…
bc4103b 
…Tests`
@maratal
Replaced static channel names with the unique ones in `RestClientPres…
8395d9d 
…enceTests`
@maratal
Replaced static channel names with the unique ones in UtilitiesTests
6c47a5d
@maratal
Fix for testIdentifier in "test__009..." in RealtimeClientTests
fe46d76
@maratal
Replaced static channel names with the unique ones in `RealtimeClient…
91d114a 
…ChannelTests`
@maratal
Flaky test discovered
41f88fe
@maratal maratal marked this pull request as draft February 7, 2022 22:17
@maratal maratal linked an issue Feb 7, 2022 that may be closed by this pull request
Unique test channel names #1280
Closed
@maratal
Replaced static channel names with the unique ones in `RealtimeClient…
1ad5584 
…ConnectionTests`
@maratal
Replaced static channel names with the unique ones in `RealtimeClient…
baf5a30 
…PresenceTests`
@maratal
Flaky test discovered
9bf419e
@maratal
Removed global channelName variable in RealtimeClientPresenceTests
2bc849d
@maratal
Replaced NSUUID().uuidString channel names with the unique ones in …
56a4677 
…`RealtimeClientPresenceTests`
@maratal
Replaced static channel names with the unique ones in `RealtimeClient…
901eab4 
…ChannelsTests`
@maratal
Replaced static channel names with the unique ones in `PublishTestMes…
fc24567 
…sage` utility class
@maratal
Replaced static channel names with the unique ones in AuthTests
2f1b845
@maratal
Replaced static channel names with the unique ones in PushChannelTests
a24e925
@maratal
Replaced static channel names with the unique ones in PushAdminTests
a4f6033
@maratal
Replaced static channel names with the unique ones in `ReadmeExamples…
85a7abc 
…Tests`
@maratal
Replaced static channel names with the unique ones in DeltaCodecTests
637f4a6
@maratal
Replaced static channel names with the unique ones in `ObjectLifetime…
7ee8a3d 
…sTests`
@maratal maratal marked this pull request as ready for review February 9, 2022 16:01
lawrence-forooghian
lawrence-forooghian reviewed Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A heroic job, well done 💪 – a few comments

Spec/Tests/RestClientChannelTests.swift Show resolved Hide resolved
Spec/Tests/RealtimeClientTests.swift Show resolved Hide resolved
Spec/Test Utilities/TestUtilities.swift Outdated Show resolved Hide resolved
QuintinWillison
QuintinWillison approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only really looked closely at the addition to test utilities, and then skim read the rest, but looks good to me.

@lawrence-forooghian
Copy link
Collaborator

I'm going to merge this, since I'm keen to run the tests in a loop and see if this has made any difference to our test success rate.

@lawrence-forooghian lawrence-forooghian merged commit 3c3763c into main Mar 12, 2022
@lawrence-forooghian lawrence-forooghian deleted the fix/1280-unique-test-channel-names branch March 12, 2022 07:43
@lawrence-forooghian lawrence-forooghian mentioned this pull request Mar 12, 2022
Closed
@lawrence-forooghian lawrence-forooghian mentioned this pull request Apr 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasz-szyszkowski lukasz-szyszkowski lukasz-szyszkowski approved these changes

@lawrence-forooghian lawrence-forooghian lawrence-forooghian approved these changes

@QuintinWillison QuintinWillison QuintinWillison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unique test channel names
4 participants
@maratal @lawrence-forooghian @QuintinWillison @lukasz-szyszkowski