-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set message encoding for valid utf-8 string data #370
Conversation
@lmars , seems Lines 87 to 91 in 4c447dc
|
Also, we can remove this //todo comment, since proto is merged into ably Line 42 in 4c447dc
|
@lmars , not sure but I feel when we are using cipher, we are adding extra layer of encoding for byte [] type, which increases payload size (33 %, goes exponential for next encoding iterations). I was thinking maybe you can improve on that one/ cut the part of code that does that when cipher is enabled. Although, this is not part of the fix. but I just feel we can include it as a part of fix |
Yes, so whilst what you describe could potentially be a problem, let's deal with that separately, the priority here is fixing the behaviour we know is broken. If you're happy that we've fixed the reported issue, please approve this PR so we can merge and release it. |
See explanation in https://github.com/ably/docs/issues/1165. Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
153c932
to
c955e6d
Compare
Fixes incomplete #107 |
See explanation in ably/specification#28.