Remove callbacks part 1 #1541
Merged
Remove callbacks part 1 #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
cb4184d
to
28f4ae5
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
28f4ae5
to
17b6103
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
17b6103
to
6c0a302
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
6c0a302
to
9b895a4
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
9b895a4
to
92c15f1
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
92c15f1
to
a441596
Compare
lawrence-forooghian
changed the base branch from
integration/v2
to
2023-12-11-merge-main-into-v2
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
github-actions
bot
temporarily deployed
to
staging/pull/1541/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1541/typedoc
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
a441596
to
0ca6d7e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1541/features
The `throwError` parameter here is to handle the fact that, when using an HttpPaginatedResponse, PaginatedResource wishes to have access to both the error that comes from the HTTP client _and_ the response body, before deciding how to handle an error (see the `returnErrOnly` function). I’ve converted Resource.do to return a promise here, but I’ll do the full conversion of that method in a separate commit for readability’s sake.
Resolves #1528.
The changes to the `connectionQueuing` test are because the test assumed that the message would get marked as `sendAttempted` synchronously as soon as `publish` was called. This relied on the fact that when no encryption is required, the Message `encode` function called its callback synchronously. However, this was an implementation detail (this function has an asynchronous signature), and one which is no longer true now that promises are used.
Missed this in a0105eb.
I’ve removed the redundant upfront generation of the IV and just kept the generation in `getIv`; this makes it consistent with the web crypto code.
lawrence-forooghian
force-pushed
the
remove-callbacks-part-1
branch
from
14e1e5b
to
b429c13
Compare
VeskeR
approved these changes
Jan 30, 2024
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the internal use of callbacks in the codebase, except for the HTTP clients and the realtime functionality. I'll do these in subsequent PRs. See commit messages for more details.
Resolves #1527, resolves #1531, resolves #1532, resolves #1530, resolves #1528.
Jira links: