Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4201] Convert HTTP code to use promises #1603

Merged
merged 16 commits into from
Feb 21, 2024
Merged

[ECO-4201] Convert HTTP code to use promises #1603

merged 16 commits into from
Feb 21, 2024

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Jan 30, 2024 •
edited
Loading

Resolves #1533. See commit messages for more details.

@github-actions github-actions bot temporarily deployed to staging/pull/1603/features January 30, 2024 17:56 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from 742dee8 to 3118ff9 Compare January 30, 2024 18:09
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features January 30, 2024 18:09 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc January 30, 2024 18:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report January 30, 2024 18:10 Inactive
Base automatically changed from remove-callbacks-part-1 to integration/v2 January 31, 2024 12:11
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from 3118ff9 to 5eb4a70 Compare February 1, 2024 17:31
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 1, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 1, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 1, 2024 17:32 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from 5eb4a70 to 9ccf880 Compare February 7, 2024 16:06
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 7, 2024 16:06 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 7, 2024 16:07 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 7, 2024 16:07 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from 9ccf880 to dc01ee5 Compare February 7, 2024 16:24
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 7, 2024 16:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 7, 2024 16:26 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 7, 2024 16:26 Inactive
@lawrence-forooghian lawrence-forooghian mentioned this pull request Feb 7, 2024
Open
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from dc01ee5 to 8775cba Compare February 8, 2024 17:31
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 8, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 8, 2024 17:32 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 8, 2024 17:32 Inactive
@lawrence-forooghian lawrence-forooghian force-pushed the 1533-remove-callbacks-from-http-code branch from 8775cba to 8902807 Compare February 8, 2024 19:51
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 8, 2024 19:51 Inactive
@lawrence-forooghian lawrence-forooghian changed the title 1533 remove callbacks from http code [SDK-3982] remove callbacks from http code Feb 8, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 8, 2024 19:52 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 8, 2024 19:52 Inactive
@lawrence-forooghian lawrence-forooghian changed the title [SDK-3982] remove callbacks from http code [SDK-3982] Convert HTTP code to use promises Feb 8, 2024
@lawrence-forooghian lawrence-forooghian mentioned this pull request Feb 15, 2024
Closed
@lawrence-forooghian
Tighten type of requestToken’s tokenRequestCallback variable
d9cd505
@lawrence-forooghian
Tighten type of requestToken’s tokenRequest variable
aeac6e2
@lawrence-forooghian
Make RequestCallback’s error param non-optional
5714753 
For consistency with our other callbacks.
@lawrence-forooghian
Convert IPlatformHttp.checkConnectivity to use promises
e6d6bb5
@lawrence-forooghian
Convert Http.checkConnectivity to use promises
865f224
@lawrence-forooghian
Convert IPlatformHttp.doUri to use promises
6f00409 
The approach taken here is the same as that taken in 2001675, in order
to be able to emit both an error _and_ the response body.

Note that in the "just in case" handling of thrown errors I’ve just
typed the thrown error as `any` and not worried about the consequences
of doing so; we can figure out how to handle this properly and
consistently in #1617.
@lawrence-forooghian
Convert Http.doUri to use promises
c663352
@lawrence-forooghian
Fix an argument name
f3e09ef
@lawrence-forooghian
Convert Http.do to use promises
9e15e4c
@lawrence-forooghian
Convert web HTTP Request to use promises
b236107
@github-actions github-actions bot temporarily deployed to staging/pull/1603/features February 15, 2024 19:59 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/bundle-report February 15, 2024 20:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1603/typedoc February 15, 2024 20:00 Inactive
@lawrence-forooghian
Convert fetchRequest to use promises
3004ccc 
Resolves #1533.
@lawrence-forooghian
Remove RequestCallback type assertions
d0568d7 
The type assertions masked quite a few inconsistencies, which I’ve
attempted to handle here.
@lawrence-forooghian
Rename types that refer to RequestCallback
2cf5a6b 
We removed RequestCallback in d0568d7.
@jamienewcomb jamienewcomb changed the title [SDK-3982] Convert HTTP code to use promises [ECO-4201] Convert HTTP code to use promises Feb 18, 2024
@VeskeR VeskeR mentioned this pull request Feb 19, 2024
Merged
@lawrence-forooghian lawrence-forooghian merged commit 5fa866d into integration/v2 Feb 21, 2024
12 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 1533-remove-callbacks-from-http-code branch February 21, 2024 13:38
@lawrence-forooghian lawrence-forooghian mentioned this pull request Feb 21, 2024
Closed
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VeskeR VeskeR VeskeR approved these changes

@owenpearson owenpearson Awaiting requested review from owenpearson

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawrence-forooghian @VeskeR