Remove Node 12 and es5 code that was supporting older platforms in v2 #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1641/features
VeskeR
force-pushed
the
remove-more-old-code
branch
from
f8a526c
to
6d2b8ec
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/features
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1641/typedoc
VeskeR
force-pushed
the
1605/v2-platform-compatibility
branch
from
26db010
to
e0f37de
Compare
VeskeR
force-pushed
the
remove-more-old-code
branch
from
6d2b8ec
to
2017263
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
VeskeR
force-pushed
the
1605/v2-platform-compatibility
branch
from
e0f37de
to
b445729
Compare
VeskeR
force-pushed
the
remove-more-old-code
branch
from
2017263
to
df37319
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
VeskeR
force-pushed
the
remove-more-old-code
branch
from
df37319
to
c0f1836
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
VeskeR
force-pushed
the
remove-more-old-code
branch
from
c0f1836
to
b345281
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
VeskeR
force-pushed
the
remove-more-old-code
branch
from
b345281
to
3e722b8
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
|
Removed |
VeskeR
force-pushed
the
remove-more-old-code
branch
from
3e722b8
to
05bc61f
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
Base automatically changed from
1605/v2-platform-compatibility
to
integration/v2
March 5, 2024 20:37
lawrence-forooghian
approved these changes
Mar 6, 2024
VeskeR
force-pushed
the
remove-more-old-code
branch
from
05bc61f
to
f1472db
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1641/bundle-report
Related to 9a05dc8, we now allow prettier to put trailing commas in more places that were not supported in ES5, and only became available in ES2017 [1], namingly: function parameters and function calls. This also enables trailing commas in type parameters in TypeScript - supported since TypeScript 2.7. [1] https://prettier.io/docs/en/options.html#trailing-commas
Also run `npm uninstall babel-loader @babel/preset-env`, we don't use them anymore after removing Node 12 code from webpack for MochaJUnitReporter.
After 4f887c6 there is no need anymore to build a separate MochaJUnitReporter bundle for Node.js - we can use `mocha-junit-reporter` package directly from Node. As a result, we also don't need `webpack-node-externals` package anymore, so run `npm uninstall webpack-node-externals`
VeskeR
force-pushed
the
remove-more-old-code
branch
from
f1472db
to
8b387f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1633 so review that one first.
Removes more code that's supporting older platforms. These commits couldn't be included in #1629, since it would break CI for them due to it still being built and tested on es5 and node 12.