[ECO-4776] Re-add main and browser fields to package.json
#1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those fields were removed in de5ddfa and replaced with `exports` field we currently use. However, removal of root level entry fields from `package.json` have caused issues with importing `ably` in some setups: - React Native wasn't able to resolve `ably` at all, due to `exports` field resolution is not enabled by default yet [1] (we fixed this by re-adding root level `react-native` field in #1713) - older bundler versions do not support `exports` field, for example, webpack has added support for `exports` only in v5. - TypeScript added support for resolving `exports` field only in its 4.7 release [2] This commit re-adds root level entry fields so those setups will still be able to resolve `ably` package. Resolves #1751 [1] https://reactnative.dev/blog/2023/06/21/package-exports-support [2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those fields were removed in de5ddfa and replaced with
exportsfield we currently use. However, removal of root level entry fields frompackage.jsonhave caused issues with importingablyin some setups:ablyat all, due toexportsfield resolution is not enabled by default yet [1] (we fixed this by re-adding root levelreact-nativefield in fix: react-native TextEncoder/TextDecoder polyfill + restore package.json react-native field #1713)exportsfield, for example, webpack has added support forexportsonly in v5.exportsfield only in its 4.7 release [2]This commit re-adds root level entry fields so those setups will still be able to resolve
ablypackage.Resolves #1751
[1] https://reactnative.dev/blog/2023/06/21/package-exports-support
[2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing