Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSA4b1 Detect expired token to avoid extra request #147

Merged
merged 2 commits into from
Apr 28, 2019
Merged

RSA4b1 Detect expired token to avoid extra request #147

merged 2 commits into from
Apr 28, 2019

Conversation

jdavid
Copy link
Contributor

@jdavid jdavid commented Apr 11, 2019 •
edited
Loading

Implement RSA4b1 and RSA10k

@jdavid jdavid changed the title Rsa4b1 RSA4b1 Detect expired token to avoid extra request Apr 11, 2019
mattheworiordan
mattheworiordan approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, although admittedly a quick cursory scan over this implementation which appears to be valid.

@jdavid jdavid merged commit 71ce1d2 into develop Apr 28, 2019
@jdavid jdavid deleted the RSA4b1 branch April 28, 2019 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheworiordan mattheworiordan mattheworiordan approved these changes

@paddybyers paddybyers Awaiting requested review from paddybyers

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdavid @mattheworiordan