Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message pack #35

Merged
merged 5 commits into from
Sep 23, 2015
Merged

Message pack #35

merged 5 commits into from
Sep 23, 2015

Conversation

aericson
Copy link
Contributor

Addresses the following

  • (RSC8) Supports two protocols:
    • (RSC8a) MessagePack binary protocol (this is the default for environments having a suitable level or support for binary data), see http://msgpack.org/ for more info
    • (RSC8b) JSON text protocol (used when useBinaryProtocol option is false)
  • (RSL4) Message encoding
    • (RSL4c) When using MessagePack Message encoding
      • (RSL4c1) a binary Message payload is encoded as MessagePack binary type
      • (RSL4c2) a string Message payload is encoded as MessagePack string type
      • (RSL4c3) a JSON Message payload is stringified either as a JSON Object or Array and encoded as MessagePack string type and the encoding attribute is set to “json”
      • (RSL4c4) All messages received will deliver payloads in the format they were sent in i.e. binary, string, or a structured type containing the parsed JSON
  • (TO3) The attributes of ClientOptions consist of:
    • (TO3f) useBinaryProtocol boolean – defaults to true. If false, forces the library to use the JSON encoding for REST and Realtime operations, instead of the default binary msgpack encoding

@mattheworiordan
Copy link
Member

Thanks, this looks good.

@aericson, can you comment on to what extent spec (G1) Every test should be executed using all supported protocols (i.e. JSON and MessagePack if supported). This includes both sending & receiving data. is implemented? Are all integration tests now run in MsgPack and JSON?

@aericson
Copy link
Contributor Author

@mattheworiordan This will come with stats on next PR

fjsj added a commit that referenced this pull request Sep 23, 2015
@fjsj fjsj merged commit 2486558 into ably:master Sep 23, 2015
@aericson aericson deleted the message-pack branch September 25, 2015 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants