Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default fallback hosts when custom environment set #196

Merged
merged 8 commits into from
May 5, 2021

Conversation

mattheworiordan
Copy link
Member

When environment is set in the client SDKs, we can now rely on default fallback hosts as follows.

Fallbacks are ENV-[a-e]-fallback.ably-realtime.com. For example:

ENV-a-fallback.ably-realtime.com
ENV-b-fallback.ably-realtime.com
ENV-c-fallback.ably-realtime.com
ENV-d-fallback.ably-realtime.com
ENV-e-fallback.ably-realtime.com

Note that this change:

  • It breaks a lot of tests against sandbox that assumed no fallback hosts would be used
  • We need to ensure that custom hosts or custom ports result do not use default environment fallback hosts. We should only use when only the custom environment is set
  • Some spec updates are needed in the spec relating to the use of fallback hosts

See related issue ably/docs#818 (no spec yet exists)

@lmars
Copy link
Member

lmars commented Feb 24, 2020

Just to note, we should not release this until we've run a DNS update to ensure all the fallbacks exist.

@lmars
Copy link
Member

lmars commented Sep 30, 2020

DNS updates have all been run so this is no longer blocked on that.

In response to points in the description:

It breaks a lot of tests against sandbox that assumed no fallback hosts would be used

Sandbox now has fallback hosts configured, in case that was the reason for the failures?

Some spec updates are needed in the spec relating to the use of fallback hosts

The spec was updated in ably/docs#965.

When environment is set in the client SDKs, we can now rely on default fallback hosts as follows.

Fallbacks are ENV-[a-e]-fallback.ably-realtime.com. For example:

ENV-a-fallback.ably-realtime.com
ENV-b-fallback.ably-realtime.com
ENV-c-fallback.ably-realtime.com
ENV-d-fallback.ably-realtime.com
ENV-e-fallback.ably-realtime.com

Note that this change:

- It breaks a lot of tests against sandbox that assumed no fallback hosts would be used
- We need to ensure that custom hosts or custom ports result do not use default environment fallback hosts.  We should only use when only the custom environment is set
- Some spec updates are needed in the spec relating to the use of fallback hosts

See related issue ably/docs#818 (no spec yet exists)
@TheSmartnik TheSmartnik force-pushed the feature/default-customer-environment-fallbacks branch from 9a222e2 to b42301c Compare November 30, 2020 15:34
@SimonWoolf
Copy link
Member

@TheSmartnik @QuintinWillison This PR was made before the spec https://github.com/ably/docs/pull/965/files was finalised. It may all be fine, but should go through that spec and check that this PR implements the final spec correctly

@jamienewcomb
Copy link
Member

@TheSmartnik did you managed to look at Simons comment
#196 (comment)

If you are happy could you approve and we will get this merged

Thanks

@TheSmartnik
Copy link
Collaborator

@jamienewcomb sorry, I've missed the comment. I'll double-check it later today and reply

@kavalerov kavalerov linked an issue Apr 15, 2021 that may be closed by this pull request
@lmars
Copy link
Member

lmars commented Apr 15, 2021

@TheSmartnik it would be great to get this merged, did you get chance to review Simon's comment?

owenpearson and others added 5 commits April 30, 2021 14:14
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
@owenpearson owenpearson merged commit d04ea64 into main May 5, 2021
@owenpearson owenpearson deleted the feature/default-customer-environment-fallbacks branch May 5, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Default fallback hosts for custom environments
7 participants