Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEB-3842] - Change Meganav menu name #406

Merged
merged 4 commits into from
Jul 10, 2024
Merged

[WEB-3842] - Change Meganav menu name #406

merged 4 commits into from
Jul 10, 2024

Conversation

aralovelace
Copy link
Contributor

Jira Ticket Link / Motivation

WEB-3842

Summary of changes

  • Updated the menu title
  • added some webstorm configs

How do you manually test this?

  • In the Storybook page, go to Meganav - Default
  • Click Solutions
  • and Dropdown menu appear, the menu on the right should be updated

Reviewer Tasks (optional)

Updated to this:

Screenshot 2024-07-10 at 11 46 34

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

Webstorm  gives error for react jsx in tsx files
From “Sports, Media & Audience Engagement” to Sports, Media & Fan Engagement”
Copy link
Member

@jamiehenson jamiehenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

This looks good, let's get a practice release in here as well. The automated release code still needs a bit of work, but what I would recommend here is to pre-bump the package.json version yourself in this PR to 14.1.3, and then once merged you'll be ready to make the GitHub release as the README says (i.e. no need to do the pre-release)

@aralovelace aralovelace merged commit e1b2854 into main Jul 10, 2024
3 checks passed
@aralovelace aralovelace deleted the WEB-3842 branch July 10, 2024 12:48
@aralovelace aralovelace added dependencies Pull requests that update a dependency file and removed review labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

2 participants