[WEB-3979] 14.5.2 - enhanced typings for icons and colours, updated neutral colours #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiehenson
commented
Sep 11, 2024
| @@ -0,0 +1,101 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
This file has mainly just been moved, just changed the arguments to iconSet
aralovelace
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Nice! just have 1 question
I will just add this change once this PR goes live
| @@ -0,0 +1,196 @@ | |||
| export type IconName = | |||
There was a problem hiding this comment.
This is incredible! Neatly done!
| --color-neutral-300: #edf1f7; | ||
| --color-neutral-100: #f6f8fa; | ||
| --color-neutral-200: #eef1f6; | ||
| --color-neutral-300: #e6eaf0; |
There was a problem hiding this comment.
Do we need to check the pages that affect these changes? or not a lot of difference between these colors?
There was a problem hiding this comment.
Pretty subtle changes - we can just roll this out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket Link / Motivation
The typing work is a side-chore (WEB-3979), the colour updates are https://ably.atlassian.net/browse/WEB-3987
Summary of changes
The colour updates are fairly simple,
neutral-100toneutral-500have been updated with new values.The typing work consists of generating union types for all the possible icon names and Tailwind colour classes, so that we can add further guards around props that use them - this PR adds them as such.
For example, on the
Iconcomponent, the value we pass intonamecan no longer just be a string, it has to match a list of icons that we actually have - this prevents accidental errors and highlights gaps inably-uiif we need to add new icons.How do you manually test this?
It's a behind the scenes change, so pull it down and mess with some icon name and colour props, I guess.
Reviewer Tasks (optional)
Merge/Deploy Checklist
Frontend Checklist