Release/1.3.1 #18
Merged
Release/1.3.1 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-xD
requested review from
paddybyers,
maratal,
lukasz-szyszkowski and
AndyNicks
AndyNicks
approved these changes
Aug 10, 2021
maratal
approved these changes
Aug 10, 2021
lukasz-szyszkowski
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A release to fix compilation failures in ably-cocoa when users depend on another library which also uses
HAVE_CONFIG_Hmacro. This was reported internally https://ably-real-time.slack.com/archives/D01V9JZV5QS/p1628580268000500 and on https://ably-real-time.slack.com/archives/C027Q92PJB1/p1627645347002000This fix may also resolve #1, @lukasz-szyszkowski can you confirm?
Temporary workaround for users: as @QuintinWillison has said in slack: