-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update configuration and running locally docs #6
Conversation
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
I added 6a19f7c to upload the ZIP archive to sdk.ably.com, for example: https://sdk.ably.com/builds/ably/kafka-connect-ably/pull/6/ably-kafka-connect-ably-1.0-SNAPSHOT.zip Once this is merged, it'll be available at: https://sdk.ably.com/builds/ably/kafka-connect-ably/main/ably-kafka-connect-ably-1.0-SNAPSHOT.zip |
1bb5434
to
5617b06
Compare
Signed-off-by: Lewis Marshall <lewis.marshall@ably.com>
So I realised that some docs are rendered out into the https://sdk.ably.com/builds/ably/kafka-connect-ably/pull/6/ The nice thing about this is the auto-generated config docs: https://sdk.ably.com/builds/ably/kafka-connect-ably/pull/6/sinks/ChannelSinkConnector.html |
Why is this all in the |
I assumed there was some historic reason (e.g. we're registered under |
Historically that was true for Maven Central, but nonetheless we're now building stuff in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
This updates the README to have separate "Installation", "Configuration" and "Running locally" sections, adds a commented configuration file, and enables the
kafka-connect-maven-plugin
to output a ZIP file that can be installed into Kafka Connect clusters.Closes #8