Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demo dependencies #106

Merged
merged 5 commits into from
Aug 9, 2023
Merged

Update demo dependencies #106

merged 5 commits into from
Aug 9, 2023

Conversation

surminus
Copy link
Collaborator

@surminus surminus commented Aug 9, 2023

Since the demo was reworked the dependencies have changed.

Explicitly install esbuild, which resolved the following error when I tried to install:

npm ERR! code 1
npm ERR! path /home/laura/ably/spaces/demo/node_modules/esbuild
npm ERR! command failed
npm ERR! command sh -c -- node install.js
npm ERR! /home/laura/ably/spaces/demo/node_modules/esbuild/install.js:132
npm ERR!     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
npm ERR!           ^
npm ERR!
npm ERR! Error: Expected "0.18.16" but got "0.17.15"
npm ERR!     at validateBinaryVersion (/home/laura/ably/spaces/demo/node_modules/esbuild/install.js:132:11)
npm ERR!     at /home/laura/ably/spaces/demo/node_modules/esbuild/install.js:285:5
npm ERR!
npm ERR! Node.js v18.13.0

Since the demo was reworked the dependencies have changed.

Explicitly install `esbuild`, which resolved the following error when I
tried to install:

```
npm ERR! code 1
npm ERR! path /home/laura/ably/spaces/demo/node_modules/esbuild
npm ERR! command failed
npm ERR! command sh -c -- node install.js
npm ERR! /home/laura/ably/spaces/demo/node_modules/esbuild/install.js:132
npm ERR!     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
npm ERR!           ^
npm ERR!
npm ERR! Error: Expected "0.18.16" but got "0.17.15"
npm ERR!     at validateBinaryVersion (/home/laura/ably/spaces/demo/node_modules/esbuild/install.js:132:11)
npm ERR!     at /home/laura/ably/spaces/demo/node_modules/esbuild/install.js:285:5
npm ERR!
npm ERR! Node.js v18.13.0
```
Dominik Piatek added 4 commits August 9, 2023 16:33
This only until the updates from #103 are merged.
This allows us to test and debug easily.
@dpiatek dpiatek merged commit fd39e27 into main Aug 9, 2023
5 checks passed
@dpiatek dpiatek deleted the laura-demo-dependencies branch August 9, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants