Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMB-202] Add documentation for simple connection and channels management #110

Merged
merged 4 commits into from
Sep 1, 2023

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Aug 11, 2023

No description provided.

Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've suggested some changes and added some comments

docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
@dpiatek dpiatek marked this pull request as ready for review August 29, 2023 16:20
@dpiatek dpiatek force-pushed the mmb-202-simple-connection-managment branch from e51c24d to 4094ee2 Compare August 30, 2023 09:51
Copy link
Member

@Srushtika Srushtika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, added minor comments. Thanks!

docs/connection-and-channel-management.md Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
docs/connection-and-channel-management.md Show resolved Hide resolved
docs/connection-and-channel-management.md Outdated Show resolved Hide resolved
@dpiatek dpiatek force-pushed the mmb-202-simple-connection-managment branch from a344ae6 to 98546ae Compare September 1, 2023 10:38
@dpiatek dpiatek force-pushed the mmb-202-simple-connection-managment branch from 98546ae to 0910283 Compare September 1, 2023 10:39
@dpiatek dpiatek merged commit 32ce87e into main Sep 1, 2023
5 checks passed
@dpiatek dpiatek deleted the mmb-202-simple-connection-managment branch September 1, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants