[MMB-154] A few small fixes for CDN publishing #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I want to test this with the `nonprod` account just to double-check it doesn't do anything... unexpected. Ensure we can use a different role.
We don't really need to authenticate with npm, but not setting the token
results in the error:
```
Error: Failed to replace env in config: ${NPM_TOKEN}
```
Also use `npm ci` to install dependencies, like we do in the release
action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this on this branch and successfully uploaded the bundle here: https://nonprod-cdn.ably.com/spaces/0.0.12/iife/index.bundle.js
See commits for details.