Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy-display-function-overlay conflicts with highlight-parentheses-mode #1547

Closed
finalpatch opened this issue Apr 29, 2018 · 2 comments
Closed

Comments

@finalpatch
Copy link

If highlight-parentheses-mode is enabled and point is in parentheses, ivy-display-function-overlay's pop up will have hl-paren-face.

To reproduce this, just install and enable highlight-parentheses-mode, then press C-M-i to complete a lisp function call.

In the linked image below, I was using default theme, so text color was supposed to be black, but everything looked red because highlight-parentheses-mode shows the inner most parentheses in red.

Image of Yaktocat

@basil-conto
Copy link
Collaborator

This looks similar to #1488.

@abo-abo
Copy link
Owner

abo-abo commented Nov 27, 2018

Thanks, please test.

basil-conto added a commit to basil-conto/swiper that referenced this issue Nov 27, 2018
This is a refactor of the following commit:

ivy-overlay.el (ivy-overlay-show-after): Don't inherit existing face
  2018-11-27 12:31:32 +0100 7434a79

(ivy--overlay-font-lock-hack): Remove.
(ivy-overlay-show-after): Specify default face of ivy-overlay-at to
avoid clashing with other overlays.

Re: abo-abo#1016, abo-abo#1488, abo-abo#1520, abo-abo#1547, abo-abo#1808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants