non-zero exit code on failure #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Patch looks good from a quick/casual review. I'm off to the beach today (with visiting cousin). Will merge and release tomorrow. |
|
Merged and released into 1.1.30. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Alex,
I hope you're doing well!
I noticed that s3cp commands return zero on failures.
This pull request fixes that in addition to centralizing the error handing in one place, cf S3CP#standard_exception_handling in
utils.rb#s3_to_localis also made more robust in case the source key is not specified by the user, or does not exist in S3.see you soon,
Alexis