Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file fingerprint #7

Merged
merged 11 commits into from
May 8, 2024
Merged

Update file fingerprint #7

merged 11 commits into from
May 8, 2024

Conversation

JonoYang
Copy link
Member

@JonoYang JonoYang commented May 6, 2024

This PR updates the file fingerprint checksum to also include the number of elements that went into the hash. New tests have been added to profile BitAverageHaloHash behavior

    * Add the number of ngrams hashed to the file fingerprint

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang requested a review from pombredanne May 6, 2024 20:31
tests/test_halohash.py Outdated Show resolved Hide resolved
Copy link
Member Author

@JonoYang JonoYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pombredanne I have a question about testing the average hamming distance values

    * Update .gitignore

Signed-off-by: Jono Yang <jyang@nexb.com>
    * This is to get a better standard deviation
    * Refactor common code

Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
    * This is to reduce CI run time

Signed-off-by: Jono Yang <jyang@nexb.com>
@JonoYang JonoYang merged commit 4908b25 into main May 8, 2024
6 checks passed
@JonoYang JonoYang deleted the update-file-fingerprint branch May 8, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants