Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nix flake as a build system #78

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

sbruder
Copy link
Contributor

@sbruder sbruder commented Jul 22, 2022

This PR is a part of the Summer of Nix project, which is funded by an EU grant connected to NGI Zero and NLNet. We are packaging software funded by and tightly related to NGI Zero projects.

It adds a build expression for Nix, a purely functional package manager that helps with achieving reproducibility.

Please let me know if you have any questions about this.

Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! See a few nits inline.

default.nix Outdated Show resolved Hide resolved
flake.nix Outdated
overlays.default = import ./overlay.nix;
}) // (
let
supportedSystems = [ "x86_64-linux" "aarch64-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, this runs on all OS and arches.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s right, at least Darwin should be in there. Since nixpkgs support for systems besides Linux and Darwin is currently spotty, I wouldn’t add any other systems to there for now, because it might be broken because of some dependency in nixpkgs. I’ll set this to include {aarch64,x86_64}-{darwin,linux}, which is what the official nixpkgs binary cache currently provides, though I can’t test if it builds on Darwin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point I was making is that the code is not architecture-specific at all, so IMHO we should not constraint supportedSystems? But I may not understand everything there.

shell.nix Outdated Show resolved Hide resolved
Signed-off-by: Simon Bruder <simon@sbruder.de>
@sbruder
Copy link
Contributor Author

sbruder commented Jul 26, 2022

Thanks for the review! I believe I addressed your points.

@pombredanne
Copy link
Member

Sorry for the late merge!

@pombredanne pombredanne merged commit 5dc7d88 into aboutcode-org:main Apr 10, 2023
keshav-space pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants