-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nix flake as a build system #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! See a few nits inline.
flake.nix
Outdated
overlays.default = import ./overlay.nix; | ||
}) // ( | ||
let | ||
supportedSystems = [ "x86_64-linux" "aarch64-linux" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this runs on all OS and arches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s right, at least Darwin should be in there. Since nixpkgs support for systems besides Linux and Darwin is currently spotty, I wouldn’t add any other systems to there for now, because it might be broken because of some dependency in nixpkgs. I’ll set this to include {aarch64,x86_64}-{darwin,linux}, which is what the official nixpkgs binary cache currently provides, though I can’t test if it builds on Darwin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point I was making is that the code is not architecture-specific at all, so IMHO we should not constraint supportedSystems? But I may not understand everything there.
Thanks for the review! I believe I addressed your points. |
Sorry for the late merge! |
Bump github actions versions #75
This PR is a part of the Summer of Nix project, which is funded by an EU grant connected to NGI Zero and NLNet. We are packaging software funded by and tightly related to NGI Zero projects.
It adds a build expression for Nix, a purely functional package manager that helps with achieving reproducibility.
Please let me know if you have any questions about this.