Unused local variables should be removed #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,16 +43,6 @@ public static void basicExample001() throws IOException { | |||
| // Strings, Buffers and byte-arrays. | |||
| final SipMessage msg = SipMessage.frame(rawMessage); | |||
|
|
|||
| // Once the message has successfully been parsed you | |||
| // can access headers etc within the SIP message. | |||
| final FromHeader from = msg.getFromHeader(); | |||
There was a problem hiding this comment.
These are examples. Please keep
|
A few comments that I would like to have addressed before merging. Question: did the unit tests actually pass after these changes? |
|
closing since the comments where never answered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule
squid:S1481 Unused local variables should be removed
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/squid:S1481
Please let me know if you have any questions.
Zeeshan Asghar