Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to share party link with other users #33

Closed
abozanona opened this issue May 19, 2022 · 0 comments · Fixed by #35
Closed

Add the ability to share party link with other users #33

abozanona opened this issue May 19, 2022 · 0 comments · Fixed by #35
Assignees
@abozanona
Labels
Design

Comments

@abozanona
Copy link
Owner

Is your feature request related to a problem? Please describe.
Users should have the ability to share a party link with other users that want to join their party.

Describe the solution you'd like

  • The user can generate a link for the current party. The link contains the party id and the URL of the most-top page in the current tab.
  • When a user opens the link, it will show him a page that will either show him that the extension is not installed or to click on a button to join the button.
  • Clicking on the above button will open a new tap and start a party there.
@abozanona abozanona self-assigned this May 19, 2022
abozanona added a commit that referenced this issue May 19, 2022
@abozanona
#33 add the ability to share parties links
28442e9
@abozanona abozanona linked a pull request May 19, 2022 that will close this issue
#33 add the ability to share parties links #35
Merged
abozanona added a commit that referenced this issue May 19, 2022
@abozanona
#33 Fix issues
af1200f
Mahmoud-Skafi added a commit that referenced this issue May 19, 2022
@Mahmoud-Skafi
Merge pull request #35 from abozanona/33-add-the-ability-to-share-par…
3565a82 
…ty-link-with-other-users

#33 add the ability to share parties links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abozanona abozanona

Labels
Design
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#33 add the ability to share parties links abozanona/luca
1 participant
@abozanona