Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export remember-me-service.ts #20066

Closed
1 task done
gvassao opened this issue Jun 18, 2024 · 0 comments · Fixed by #20218
Closed
1 task done

Export remember-me-service.ts #20066

gvassao opened this issue Jun 18, 2024 · 0 comments · Fixed by #20218

Comments

@gvassao
Copy link

gvassao commented Jun 18, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

My code was using the functions setRememberMe and removeRememberMe, which were removed in this PR.

I needed these functions because my app uses a password authentication flow and requires custom parameters for login. The login function only accepts LoginParams as a parameter, which doesn't allow for custom parameters.

Instead of the login function, I had to use loginUsingGrant, but this function does not account for the "remember me" feature. Previously, I relied on the setRememberMe and removeRememberMe functions to handle this, but now I can't because they have been removed.

Describe the solution you'd like

I would like to be able to use the remember-me service so I can implement the "remember me" function. However, it seems that this module is not exported because when I try to use it, I get the following error:

import { RememberMeService } from '@abp/ng.oauth/lib/services/remember-me.service';

Error: Module not found: Error: Package path ./lib/services/remember-me.service is not exported from package

Additional context

Looking at the remeber me service, I can manually set the local storage, but if ABP modifies how it handles this functionality, my code might break. I'm open to suggestions if there's another way to achieve this.

mahmut-gundogdu added a commit to mahmut-gundogdu/abp-vercel-CI-demo that referenced this issue Jul 13, 2024
@masum-ulu masum-ulu self-assigned this Jul 16, 2024
@masum-ulu masum-ulu added this to the 8.2-patch milestone Jul 16, 2024
masum-ulu added a commit that referenced this issue Jul 16, 2024
Fix #20066  - Add remember-me.service on index.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants