Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grant all permissions checkbox does not affect Select all checkbox. #18429

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Grant all permissions checkbox does not affect Select all checkbox. #18429

merged 4 commits into from
Dec 12, 2023

Conversation

Sinan997
Copy link
Contributor

@Sinan997 Sinan997 commented Dec 11, 2023 •
edited by gizemmutukurt
Loading

#15934 Resolves

selectall

@Sinan997 Sinan997 added this to the 7.4-patch-final milestone Dec 11, 2023
@masum-ulu masum-ulu requested review from gizemmutukurt and removed request for oykuermann December 11, 2023 09:18
@Sinan997 Sinan997 changed the base branch from dev to rel-7.4 December 11, 2023 09:40
@gizemmutukurt
Copy link
Contributor

gizemmutukurt commented Dec 11, 2023 •
edited by Sinan997
Loading

  • If there is only one option and it is removed, it should be removed in select all.
    image

  • If there are many selections and some have been removed, select all should be "-".
    image

gizemmutukurt
gizemmutukurt requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@gizemmutukurt gizemmutukurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be checked again when the problems are fixed.

@gizemmutukurt
Copy link
Contributor

The following situations need to be corrected.

image
image

@gizemmutukurt gizemmutukurt merged commit 55cd6e1 into rel-7.4 Dec 12, 2023
3 checks passed
@gizemmutukurt gizemmutukurt deleted the issue/15934 branch December 12, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizemmutukurt gizemmutukurt gizemmutukurt approved these changes

@masum-ulu masum-ulu masum-ulu approved these changes

Assignees
No one assigned
Labels
bug ui-angular
Projects
None yet
Milestone
7.4-patch-final
Development

Successfully merging this pull request may close these issues.
3 participants
@Sinan997 @gizemmutukurt @masum-ulu