No need to consider license-files when handling PEP 621 metadata for setuptools plugin
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in the [Packaging discourse], PEP 621' project.license.file is completely uncorrelated to the currently non-standard License-file core metadata used by setuptools. Therefore it is completely possible to dynamically define `License-file` without having to mark `license` as `dynamic`. This allow some simplifications as implemented in this change. [Packaging discourse]: https://discuss.python.org/t/help-testing-experimental-features-in-setuptools/13821/57
When an inline-table has comments, we can bubble this comments out to be associated directly with the table (otherwise they are simply removed).
Now that we clarified that PEP 621 does not specify anything about the (non-standard) core metadata field `License-file` and that it is not necessary to add `license` to `dynamic` to be able to automatically fill it, there is no motivation for keeping this field in `tool.setuptools.dynamic` instead of `tool.setuptools` (directly). Note that this is unlikely to change with PEP 639 (the draft currently establishes that the backend can backfill `license-files` without needing an explicit `dynamic` if it is not provided).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ini2tomlwas considering thatproject.licenseandproject.dynamicwere relevant for setting theLicense-fileinPKG-INFO. As clarified in a recent discussion, that is not the case:setuptoolscan fillLicense-fileeven whenproject.licenseis static andpyproject.toml'license.fileis completely unrelated tosetup.cfg'license_files.When we consider
licenseandlicense-filesseparately, we can simplify the implementation:setup.cfg licensecan be converted directly intopyproject.toml license.textsetup.cfg license-filescan be converted directly intopyproject.toml tool.setuptools.license-files(this will be reviewed after the approval of PEP 639 when there will be a standard for that field).See: