Support duplicate plugin instances in test_list_from_entry_points #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Account for the possibility of the isort plugin occurring more than once in the plugin list, in test_list_from_entry_points. This is needed to avoid test failures on Gentoo where tests are run in a venv with --system-site-packages. As a result, if ini2toml is installed already, it grabs all plugins twice — once from the venv, and then again from system site-packages directory.
|
Thank you very much Michał. |
|
Thank you! I couldn't figure out how to fix this test failure on our end, so this helps greatly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for the possibility of the isort plugin occurring more than
once in the plugin list, in test_list_from_entry_points. This is needed
to avoid test failures on Gentoo where tests are run in a venv
with --system-site-packages. As a result, if ini2toml is installed
already, it grabs all plugins twice — once from the venv, and then again
from system site-packages directory.