Remove cycleroute always having access granted #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some bicycle routes can have portions which are not accessible. Potential reasons for this: - temporary construction work on the ways (sometimes for months), - local access change without simultaneous update of bicycle route relation (lack of mapper's knowledge or lack of time to redefine an updated route), - ... This commit changes the trekking profile so that being on a cycle route does not automatically mean "access granted" for bicycles. The normal access checkings are used instead. However, the accesspenalty is set to 15 if the no-access way belongs to such a route, so that the way is not completely forbidden if there is no other alternative unavailable.
Some bicycle routes can have portions which are not accessible. Potential reasons for this: - temporary construction work on the ways (sometimes for months), - local access change without simultaneous update of bicycle route relation (lack of mapper's knowledge or lack of time to redefine an updated route), - ... This commit changes the fastbike profile so that being on a cycle route does not automatically mean "access granted" for bicycles. The normal access checkings are used instead. However, the accesspenalty is set to 15 if the no-access way belongs to such a route, so that the way is not completely forbidden if there is no other alternative unavailable.
|
Do you have an example where this behavior would help? |
|
@zod yes, here: The way that is used by brouter (along the east side of the canal) is not actually usable (and it is tagged as such), because it has construction work (duration of several month, preparing for the Olympic Games to come I believe). However, because the way belongs to a cycle route relation, brouter suggests this route with low cost, even though it is unusable. Sorry for the late answer. |
|
I haven't heard of @zod for a while. If you don't mind I'll merge the PR, I like the idea to block this ways not totally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bicycle routes can have portions which are not accessible.
Potential reasons for this:
(lack of mapper's knowledge or lack of time to redefine an updated route),
This branch changes fastbike & trekking profiles so that being on a cycle
route does not automatically mean "access granted" for bicycles. The normal
access checkings are used instead.
However, the accesspenalty is set to 15 if the no-access way belongs to such a
route, so that the way is not completely forbidden if there is no other
alternative unavailable.