Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for inner post likes, better specificity to profile buttons. #34

Closed
wants to merge 4 commits into from

Conversation

maplesyrupsucker
Copy link
Collaborator

Fixes #30 and adds a bit more specificity to buttons.

@ghost
Copy link

ghost commented Apr 24, 2018

CSS issue when reading new posts (and also other). "margin-top" is removed. I think there needs to be a better CSS for these. Something is conflicting if there isn't something wrong with my client (chrome on ubuntu).
screenshot from 2018-04-24 14-45-16

Used base64 because couldn't think of a simple way to include font files and worried about CDN font files adding to FOUC.
@maplesyrupsucker
Copy link
Collaborator Author

@lte13 I think that might just be a browser quirk or something, I can't seem to replicate it.

@maplesyrupsucker
Copy link
Collaborator Author

Added icons to navbar in commit #abc16b9 - hot stuff!

screen shot 2018-04-25 at 12 42 14 am

@ghost
Copy link

ghost commented Apr 24, 2018

@maplesyrupsucker : Yes, correct. Problem is on Chromium browser 65.0.3325.181 on Ubuntu 16.04. I think the problem might be some conflicting CSS in regards to some margin settings. I think we should clean it up and look for it and make containers,

@maplesyrupsucker
Copy link
Collaborator Author

Closing to merge into staging instead, will see if I can fix the reported browser quirk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant