Enable user to archive and unarchive #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danischreiber
force-pushed
the
group-methods
branch
from
7181e2c
to
c1b4810
Compare
|
@danischreiber can you make the methods use room_option_hash? Both calls accept roomName as well. This'll also make the API more similar to the already existing calls. |
danischreiber
force-pushed
the
group-methods
branch
from
c1b4810
to
4a026c8
Compare
|
Updated.
…On Wed, Jul 12, 2017 at 1:55 PM, Boris Peterbarg ***@***.***> wrote:
@danischreiber <https://github.com/danischreiber> can you make the
methods use room_option_hash? Both calls accept roomName as well. This'll
also make the API more similar to the already existing calls.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEWU-wfRHW56uIHHuO0enKLMiuG_MH32ks5sNKYWgaJpZM4OVbQL>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional functionality to the REST api gem. Allow users to archive and unarchive rooms. Please review ASAP.