Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get unread count for user #18

Closed
wants to merge 1 commit into from

Conversation

danischreiber
Copy link
Contributor

No description provided.

Copy link
Owner

@abrom abrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature looks good @danischreiber

Suggest we hold off merging this until the feature has been merged into the server api. That PR seems to be held up for a code format issue too??

#
def unread_count(user_id: nil, username: nil)
response = session.request_json(
'/api/v1/users.unreadCount',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the build is wanting these two lines to be only indented once vs twice

@danischreiber
Copy link
Contributor Author

danischreiber commented Sep 4, 2017 via email

@abrom
Copy link
Owner

abrom commented Oct 25, 2017

Hey @danischreiber, it looks like your PR in the rocketchat repo for this has gone stale?? Might be worth pinging them to get a review underway

@abrom
Copy link
Owner

abrom commented Sep 28, 2018

Hey @danischreiber, still no movement on your PR in the rocketchat repo? I can't see the end-point in the users API.

@abrom abrom closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants