Validate path before opening it

[marusak]

It can happen that displayed problems gets removed outside of the
gnome-abrt and then when we try to open problem directory we end up with
crash.

Fixes #1544907

Signed-off-by: Matej Marusak mmarusak@redhat.com

[ernestask]

Would be nice to have some sort of feedback about the directory being missing in that case.

[marusak]

Agree. However showing "Directory does not exists" will just open more questions. We can try to explain it in detail what could happen. Looking for suggestions :)

[ernestask]

“This problem has been deleted using another tool and its directory no longer exists” or a variation of that, maybe? Of course, the problem should be removed from the interface as well.

[ernestask]

I think the most important parts are:

• explaining what happened (problem was removed)
• explaining how it happened (some different tool was used)
• explaining how it makes the action fail (directory no longer exists)

[ernestask]

Disappearing UI elements can be disorienting, but it prevents failures like this. If we had some sort of monitoring of the problem directories, then we could do it ahead of time, but then we would also need to add notifications or something else that would also explain how it is possible.

However, it’s rather an edge case, no?

[marusak]

This problem has been deleted using another tool and its directory no longer exists

This will bring questions like "I don't use any other tool". We should mention deduplication or that it was removed by someone.

Disappearing UI elements can be disorienting, but it prevents failures like this. If we had some sort of monitoring of the problem directories, then we could do it ahead of time, but then we would also need to add notifications or something else that would also explain how it is possible.

I don't think that removing UI elements is the solution. The solution would be to keep it there, but validate that it exists and if not make it gray or write there in red something like "invalid" and provide explanation when you click on it.

However, it’s rather an edge case, no?

Yes, it is very edge. That's why I found it sufficient not to crash. Of course it would be nicer if it would inform user what is happening etc. but for those few cases when it happens it usually is just fine. But if you have some good idea how to do it in a friendly way, do not hesitate :)

[ernestask]

This will bring questions like "I don't use any other tool". We should mention deduplication or that it was removed by someone.

And I was thinking that the “someone” could also be a bit surprising.

I don't think that removing UI elements is the solution. The solution would be to keep it there, but validate that it exists and if not make it gray or write there in red something like "invalid" and provide explanation when you click on it.

That’s not a bad idea at all, actually.

Yes, it is very edge. That's why I found it sufficient not to crash. Of course it would be nicer if it would inform user what is happening etc. but for those few cases when it happens it usually is just fine. But if you have some good idea how to do it in a friendly way, do not hesitate :)

I’m going to agree, but let’s open a new issue about this as well.