Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NegativeNaN test fails on riscv64 #1684

Closed
NeilHanlon opened this issue May 30, 2024 · 2 comments
Closed

[Bug]: NegativeNaN test fails on riscv64 #1684

NeilHanlon opened this issue May 30, 2024 · 2 comments

Comments

@NeilHanlon
Copy link

Describe the issue

When building abseil-cpp for riscv64 Fedora, we discovered one test fails:

+ # [==========] 125 tests from 35 test suites ran. (3501 ms total)
+ # [  PASSED  ] 124 tests.
+ # [  FAILED  ] 1 test, listed below:
+ # [  FAILED  ] FloatingPointLogFormatTest/0.NegativeNaN, where TypeParam = float
+ #  1 FAILED TEST

Disabling this test allows the build to complete properly: https://src.fedoraproject.org/rpms/abseil-cpp/pull-request/19

It appears that this is related to WebAssembly/design#646

Steps to reproduce the problem

Build abseil-cpp on riscv64

What version of Abseil are you using?

20240116.2

What operating system and version are you using?

Fedora (rawhide) - 41

What compiler and version are you using?

gcc-14.1.1-4.fc41 / clang-18.1.3-2.0.riscv64.fc40

What build system are you using?

cmake-3.28.3-4.fc41

Additional context

No response

@derekmauro
Copy link
Member

This might be of interest to @bbarenblat

@bbarenblat
Copy link
Contributor

Debian has observed this as well, and this test is disabled there too. We probably should apply the Debian patch here, at least until LWG 4101 is resolved. (Depending on the resolution, we may need to remove this particular test for all architectures.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants