NOISSUE - Add dtls config to CoAP cli #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
dborovcanin
requested changes
Oct 9, 2023
cert_utility/utility.go
Outdated
| clientCrtBytes := make([]byte, 2048) | ||
| caBytes := make([]byte, 2048) | ||
|
|
||
| kb, err := os.Open("../certs/client.key") |
There was a problem hiding this comment.
Use os.ReadFile and make file paths configurable.
coap/client.go
Outdated
| c, err := udp.Dial(addr) | ||
| if err != nil { | ||
| log.Fatalf("Error dialing: %v", err) | ||
| func New(addr string, to_dtls bool) (Client, error) { |
There was a problem hiding this comment.
Avoid using snake_case. Also, use switch instead of if-else.
There was a problem hiding this comment.
Try using cert and key paths to determine DTLS. If the cert path is set, try establishing DTLS connection with cert on that path.
coap/client.go
Outdated
| "github.com/plgd-dev/go-coap/v2/udp" | ||
| "github.com/plgd-dev/go-coap/v2/udp/client" | ||
| "github.com/plgd-dev/go-coap/v2/udp/message/pool" | ||
| cert_utility "github.com/mainflux/coap-cli/cert_utility" |
rodneyosodo
requested changes
Oct 12, 2023
README.md
Outdated
| @@ -15,11 +15,13 @@ When running, please provide following format: | |||
| | p | port | "5683" | | |||
| | d | data to be sent in POST or PUT | "" | | |||
| | cf | content format | 50 (JSON format) | | |||
| |tls | dtls support | false | | |||
| ## Examples: | ||
|
|
||
| ```bash | ||
| coap-cli get channels/0bb5ba61-a66e-4972-bab6-26f19962678f/messages/subtopic -auth 1e1017e6-dee7-45b4-8a13-00e6afeb66eb -o | ||
| coap-cli get channels/0bb5ba61-a66e-4972-bab6-26f19962678f/messages/subtopic -auth 1e1017e6-dee7-45b4-8a13-00e6afeb66eb -o -tls |
There was a problem hiding this comment.
Add seperate example for dtls
cert_utility/utility.go
Outdated
| @@ -0,0 +1,145 @@ | |||
| package cert_utility | |||
There was a problem hiding this comment.
Rename package name to follow guidelines https://go.dev/blog/package-names
coap/client.go
Outdated
| } | ||
|
|
||
| // Receive receives a message. | ||
| func (c Client) Receive(path string, opts ...message.Option) (*client.Observation, error) { | ||
| func (c Client) Receive(path string, opts ...message.Option) (interface { |
There was a problem hiding this comment.
Declare the returned interface somewhere first for readability
SammyOina
requested changes
Oct 12, 2023
cert_utility/utility.go
Outdated
| log.Fatal(err) | ||
| } | ||
| defer kb.Close() | ||
| kb.Read(clientKeyBytes) |
cmd/main.go
Outdated
| go func() { | ||
| c := make(chan os.Signal) | ||
| c := make(chan os.Signal, 1) // make the channel buffered |
cmd/main.go
Outdated
| @@ -123,9 +126,10 @@ func main() { | |||
| if err != nil { | |||
| log.Fatal("Error observing resource: ", err) | |||
| } | |||
| errs := make(chan error, 2) | |||
| errs := make(chan error, 1) // make the channel buffered | |||
SammyOina
requested changes
Oct 23, 2023
coap/client.go
Outdated
Comment on lines
67
to
70
| func (c Client) Receive(path string, opts ...message.Option) (interface { | ||
| Cancel(ctx context.Context, opts ...message.Option) error | ||
| Canceled() bool | ||
| }, error) { |
There was a problem hiding this comment.
Suggested change
| func (c Client) Receive(path string, opts ...message.Option) (interface { | |
| Cancel(ctx context.Context, opts ...message.Option) error | |
| Canceled() bool | |
| }, error) { | |
| func (c Client) Receive(path string, opts ...message.Option) (client.Observation, error) { |
There was a problem hiding this comment.
I dont think the Conn type has an implementation of Observation.
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Add dtls config to CoAP cli
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
Refactor coap.go to include DTLS dial.
Refactor main.go Changed functionality of New function.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
Updated the README with new instructions on building.
Notes