CONTRIBUTING.md javasript style link is dead #88
Labels
Comments
|
Fixed by mainflux/mainflux@b7863f1 Thanks for reporting. |
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this issue
Jun 9, 2021
…imizing severity vulnerabilities (absmach#88) Correction repository url Correction bugs url Upgrade/Add/Remove/Change Dependencies: Bump @agm/core from ^1.0.0 to ^1.1.0 Bump @angular/animations from ^8.2.13 to ^8.2.14 Bump @angular/common from ^8.2.13 to ^8.2.14 Bump @angular/compiler from ^8.2.13 to ^8.2.14 Bump @angular/core from ^8.2.13 to ^8.2.14 Bump @angular/forms from ^8.2.13 to ^8.2.14 Remove @angular/http (https://angular.io/guide/deprecations#angularhttp) Bump @angular/platform-browser from ^8.2.13 to ^8.2.14 Bump @angular/platform-browser-dynamic from ^8.2.13 to ^8.2.14 Bump @angular/router from ^8.2.13 to ^8.2.14 Bump @nebular/auth from 4.1.0 to 4.6.0 Bump @nebular/bootstrap from 4.1.0 to 4.6.0 Bump @nebular/eva-icons from 4.1.0 to 4.6.0 Bump @nebular/security from 4.1.0 to 4.6.0 Bump @nebular/theme from ^4.5.0 to ^4.6.0 Bump angular-tree-component from 7.2.0 to 7.2.1 Bump angular2-chartjs from 0.4.1 to 0.5.1 Bump angular2-toaster from ^7.0.0 to ^8.0.0 Bump bootstrap from 4.3.1 to 4.4.1 Bump chart.js from ^2.9.2 to ^2.9.3 Change ckeditor 4.12.1 to ckeditor4 4.14.0 (https://www.npmjs.com/package/ckeditor) Bump core-js from 2.5.1 to 2.6.11 Bump eva-icons from ^1.1.2 to ^1.1.3 Add font-awesome 4.7.0 Bump jsoneditor from ^6.4.1 to ^8.6.6 Bump leaflet from ^1.5.1 to ^1.6.0 Bump ng2-completer from 2.0.8 to 3.0.2 Bump ng2-smart-table from 1.3.5 to 1.5.0 Bump ngx-auth from ^5.2.0 to ^5.3.0 Bump ngx-mqtt from ^6.13.2 to ^6.13.3 Bump node-sass from ^4.13.0 to ^4.14.0 Bump normalize.css from 6.0.0 to 8.0.1 Add popper.js 1.16.0 Bump roboto-fontface from 0.8.0 to 0.10.0 Bump rxjs from 6.5.2 to 6.5.5 Bump rxjs-compat from 6.3.0 to 6.5.5 Bump tinymce from 4.9.7 to 4.9.10 Bump tslib from ^1.9.0 to ^1.11.1 Bump typeface-exo from 0.0.22 to 0.0.61 Bump uuid from ^3.3.3 to ^8.0.0 Upgrade/Add/Remove/Change devDependencies: Bump @angular-devkit/build-angular from ^0.800.6 to ^0.803.26 Bump @angular/cli from ^8.3.17 to ^8.3.26 Bump @angular/compiler-cli from ^8.2.13 to ^8.2.14 Bump @angular/language-service from 8.0.0 to 8.2.14 Bump @fortawesome/fontawesome-free from ^5.11.2 to ^5.13.0 Bump @types/d3-color from 1.0.5 to 1.2.2 Bump @types/googlemaps from ^3.38.0 to ^3.39.4 Bump @types/jasmine from 2.5.54 to 2.8.9 Bump @types/jasminewd2 from 2.0.3 to 2.0.8 Bump @types/node from 6.0.90 to 13.13.4 Bump codelyzer from ^5.2.0 to ^5.2.2 Bump conventional-changelog-cli from 1.3.4 to 2.0.31 Bump husky from 0.13.3 to 4.2.5 Bump jasmine-core from 2.6.4 to 3.5.0 Bump jasmine-spec-reporter from 4.1.1 to 5.0.2 Bump karma from 1.7.1 to 5.0.4 Bump karma-chrome-launcher from 2.1.1 to 3.1.0 Bump karma-cli from 1.0.1 to 2.0.0 Bump karma-coverage-istanbul-reporter from 1.3.0 to 3.0.0 Bump karma-jasmine from 1.1.0 to 3.1.1 Bump karma-jasmine-html-reporter from 0.2.2 to 1.5.3 Bump npm-run-all from 4.0.2 to 4.1.5 Bump protractor from 5.1.2 to 5.4.4 Bump rimraf from 2.6.1 to 3.0.2 Bump stylelint from 7.13.0 to 13.3.3 Bump ts-node from 3.2.2 to 8.10.1 Bump typescript from 3.4.5 to 3.5.1 Signed-off-by: Tomy Alma'arif <tomy@almaarif.info>
mteodor
pushed a commit
to mteodor/mainflux
that referenced
this issue
Nov 5, 2021
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
arvindh123
pushed a commit
to arvindh123/magistrala
that referenced
this issue
Dec 17, 2023
* feat: API layer for search Implement the API layer for search. This includes the following: - API endpoints for search - Logging - Metrics - Tracing * fix(api): fix default order in common.go The default order in the common.go file was set to "updated_by" instead of "updated_at". This commit fixes the default order to "updated_at" to ensure accurate sorting. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * test: Add test function for search clients The test function creates a new service with mock dependencies and tests various scenarios, including authorized and invalid tokens. It also checks the response and error values. The test function sets up mock calls and asserts expected values. Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> * refactor(users): remove search endpoint Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com> --------- Signed-off-by: Rodney Osodo <28790446+rodneyosodo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
I stared "playing" with Mainflux and when I was checking the contributing guide and I saw that the link to the javascript guidelines is dead.
Can someone please take a look at it?
Suggestion:
For the JavaScript/Node projects the pre-commit can be used to run a style check with automatic corrections and eventually the unit tests if there are any. This package attaches a pre-commit hook and blocks the committing to the repo if some of the checks (run scripts) .
This way it can be assured that the code is always well formatted, the unit tests pass, a linter is run and code coverage is checked.
Best Regards,
Jovan
The text was updated successfully, but these errors were encountered: