Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix MQTT Forwarder topic #1827

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

dborovcanin
Copy link
Collaborator

What does this do?

This fixes MQTT Forwarder topic formed from the channel, fixed parts, and subtopic.

Which issue(s) does this PR fix/relate to?

There is no such issue.

List any changes that modify/break current functionality

This is a bugfix.

Have you included tests for your changes?

N/A

Did you document any new/modified functionality?

It works as intended now.

Notes

N/A

@dborovcanin dborovcanin requested a review from a team as a code owner June 22, 2023 16:26
drasko
drasko previously approved these changes Jun 22, 2023
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: dusanb94 <dusan.borovcanin@mainflux.com>
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #1827 (8e625df) into master (fce91bb) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1827   +/-   ##
=======================================
  Coverage   65.69%   65.69%           
=======================================
  Files         116      116           
  Lines        9415     9415           
=======================================
  Hits         6185     6185           
  Misses       2572     2572           
  Partials      658      658           
Impacted Files Coverage Δ
mqtt/forwarder.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@drasko drasko merged commit 723dc52 into absmach:master Jun 22, 2023
@dborovcanin dborovcanin deleted the fix-mqtt-forwarder branch January 12, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants