-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Add Tracing To Certs Service #1850
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
NOISSUE-tracecerts
branch
from
July 5, 2023 18:17
e7aabf6
to
5470a7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
==========================================
- Coverage 65.68% 64.12% -1.57%
==========================================
Files 116 118 +2
Lines 9413 9642 +229
==========================================
Hits 6183 6183
- Misses 2572 2801 +229
Partials 658 658
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rodneyosodo
force-pushed
the
NOISSUE-tracecerts
branch
5 times, most recently
from
July 10, 2023 12:28
7428595
to
ddbf5c6
Compare
SammyOina
requested changes
Jul 11, 2023
rodneyosodo
force-pushed
the
NOISSUE-tracecerts
branch
from
July 11, 2023 11:14
accb5a5
to
2f5c1bb
Compare
SammyOina
approved these changes
Jul 11, 2023
rodneyosodo
force-pushed
the
NOISSUE-tracecerts
branch
3 times, most recently
from
July 12, 2023 08:50
5826b88
to
60bee29
Compare
dborovcanin
approved these changes
Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
dborovcanin
force-pushed
the
NOISSUE-tracecerts
branch
from
July 12, 2023 09:24
60bee29
to
8817c3b
Compare
drasko
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
WashingtonKK
pushed a commit
to WashingtonKK/magistrala
that referenced
this pull request
Jul 12, 2023
Signed-off-by: rodneyosodo <blackd0t@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rodneyosodo blackd0t@protonmail.com
What does this do?
Add tracing to the certs service
Which issue(s) does this PR fix/relate to?
No issue
List any changes that modify/break current functionality
context
to repository functions on CertsNamedQueryContext
instead ofNamedQuery
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
To be merged after #1849