NOISSUE - Return certs on bootstrap view response #1855

SammyOina · 2023-07-07T14:21:36Z

What does this do?

Retrieves Client_Cert, and CA_Cert when a view request is made on the bootstrap service.
Returns certs on updateCert
Use named parameters on queries

Which issue(s) does this PR fix/relate to?

No issue

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

I have added modified parameters to openapi spec

Notes

bootstrap/postgres/configs.go

codecov · 2023-07-07T17:35:54Z

Codecov Report

Merging #1855 (235364e) into master (57d47fe) will decrease coverage by 0.22%.
The diff coverage is 59.55%.

@@            Coverage Diff             @@
##           master    #1855      +/-   ##
==========================================
- Coverage   67.34%   67.12%   -0.22%     
==========================================
  Files         119      119              
  Lines        9411     9491      +80     
==========================================
+ Hits         6338     6371      +33     
- Misses       2402     2448      +46     
- Partials      671      672       +1

Files Changed	Coverage Δ
bootstrap/api/transport.go	`94.47% <ø> (ø)`
bootstrap/redis/producer/streams.go	`56.41% <0.00%> (-0.49%)`	⬇️
pkg/sdk/go/bootstrap.go	`0.00% <0.00%> (ø)`
pkg/sdk/go/sdk.go	`74.41% <ø> (ø)`
bootstrap/postgres/configs.go	`70.16% <76.56%> (+0.87%)`	⬆️
bootstrap/service.go	`80.54% <90.47%> (+0.08%)`	⬆️
bootstrap/api/endpoint.go	`100.00% <100.00%> (ø)`
bootstrap/api/responses.go	`100.00% <100.00%> (ø)`
bootstrap/reader.go	`78.37% <100.00%> (ø)`
bootstrap/redis/producer/events.go	`54.09% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

provision/service.go

bootstrap/service_test.go

drasko

LGTM

dborovcanin

Please fix CI remarks.

bootstrap/configs.go

bootstrap/api/responses.go

arvindh123 · 2023-07-28T06:37:43Z

@SammyOina
There is an other PR , which changes the flow of Bootstrap & Certs
https://github.com/mainflux/mainflux/pull/1669
https://github.com/ultravioletrs/issues/issues/124

SammyOina · 2023-07-28T08:10:32Z

@SammyOina There is an other PR , which changes the flow of Bootstrap & Certs #1669 ultravioletrs/issues#124

I see but I don't expect them to clash

Signed-off-by: SammyOina <sammyoina@gmail.com>

remove unrequired conditions Signed-off-by: SammyOina <sammyoina@gmail.com>

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <sammyoina@gmail.com>

Signed-off-by: SammyOina <sammyoina@gmail.com>

drasko

LGTM

* return certs on bootstrap view response Signed-off-by: SammyOina <sammyoina@gmail.com> * return updated certs when updated Signed-off-by: SammyOina <sammyoina@gmail.com> * fix test Signed-off-by: SammyOina <sammyoina@gmail.com> * fix test Signed-off-by: SammyOina <sammyoina@gmail.com> * fix test Signed-off-by: SammyOina <sammyoina@gmail.com> * fix test Signed-off-by: SammyOina <sammyoina@gmail.com> * fix tests Signed-off-by: SammyOina <sammyoina@gmail.com> * simplify tests Signed-off-by: SammyOina <sammyoina@gmail.com> * use named query Signed-off-by: SammyOina <sammyoina@gmail.com> * fix test Signed-off-by: SammyOina <sammyoina@gmail.com> * use named params Signed-off-by: SammyOina <sammyoina@gmail.com> * fix typo Signed-off-by: SammyOina <sammyoina@gmail.com> * use inline error checks remove unrequired conditions Signed-off-by: SammyOina <sammyoina@gmail.com> * sort slices before comparison Signed-off-by: SammyOina <sammyoina@gmail.com> * rename mainflux_id to thing_id rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <sammyoina@gmail.com> * remove mainflux_channels Signed-off-by: SammyOina <sammyoina@gmail.com> * simplify unmarshaller Signed-off-by: SammyOina <sammyoina@gmail.com> --------- Signed-off-by: SammyOina <sammyoina@gmail.com>

SammyOina requested a review from a team as a code owner July 7, 2023 14:21

dborovcanin requested changes Jul 7, 2023

View reviewed changes

bootstrap/postgres/configs.go Outdated Show resolved Hide resolved

dborovcanin approved these changes Jul 10, 2023

View reviewed changes

dborovcanin force-pushed the view-bootstrap branch from 052aedc to efcdef7 Compare July 10, 2023 14:42

dborovcanin requested changes Jul 10, 2023

View reviewed changes

provision/service.go Outdated Show resolved Hide resolved

bootstrap/service_test.go Outdated Show resolved Hide resolved

SammyOina requested a review from dborovcanin July 11, 2023 05:59

dborovcanin previously approved these changes Jul 11, 2023

View reviewed changes

drasko previously approved these changes Jul 11, 2023

View reviewed changes

SammyOina dismissed stale reviews from dborovcanin and drasko via 95de885 July 12, 2023 07:25

SammyOina force-pushed the view-bootstrap branch from 95de885 to 9e4345b Compare July 12, 2023 09:32

dborovcanin force-pushed the view-bootstrap branch from 9e4345b to 6f9a9c5 Compare July 12, 2023 10:48

dborovcanin previously approved these changes Jul 12, 2023

View reviewed changes

SammyOina force-pushed the view-bootstrap branch from 6f9a9c5 to 73c7d42 Compare July 13, 2023 07:04

SammyOina dismissed dborovcanin’s stale review via b2f7fe5 July 13, 2023 13:29

SammyOina force-pushed the view-bootstrap branch 3 times, most recently from 291871d to 14a272c Compare July 13, 2023 17:45

dborovcanin approved these changes Jul 14, 2023

View reviewed changes

dborovcanin requested changes Jul 17, 2023

View reviewed changes

SammyOina force-pushed the view-bootstrap branch from 00282e7 to af028cf Compare July 17, 2023 12:36

dborovcanin previously approved these changes Jul 17, 2023

View reviewed changes

SammyOina force-pushed the view-bootstrap branch 3 times, most recently from 8e487c7 to 5f36795 Compare July 25, 2023 16:34

SammyOina requested a review from drasko July 25, 2023 16:34

SammyOina force-pushed the view-bootstrap branch from 5f36795 to 0e2de4c Compare July 26, 2023 14:03

arvindh123 reviewed Jul 26, 2023

View reviewed changes

bootstrap/configs.go Outdated Show resolved Hide resolved

SammyOina force-pushed the view-bootstrap branch from 0e2de4c to 2d72fca Compare July 26, 2023 14:39

arvindh123 reviewed Jul 28, 2023

View reviewed changes

bootstrap/api/responses.go Show resolved Hide resolved

SammyOina force-pushed the view-bootstrap branch from 2d72fca to 83e5d58 Compare July 28, 2023 08:09

SammyOina dismissed dborovcanin’s stale review via 60df296 July 28, 2023 12:12

SammyOina force-pushed the view-bootstrap branch from 60df296 to c9ccff2 Compare July 28, 2023 13:08

SammyOina requested a review from arvindh123 July 28, 2023 13:09

SammyOina added 16 commits July 28, 2023 16:34

return certs on bootstrap view response

76743ed

Signed-off-by: SammyOina <sammyoina@gmail.com>

return updated certs when updated

8db8183

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix test

0b4d194

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix test

888e7fc

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix test

8cedc6f

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix test

48488c5

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix tests

aeb3d58

Signed-off-by: SammyOina <sammyoina@gmail.com>

simplify tests

d160e8e

Signed-off-by: SammyOina <sammyoina@gmail.com>

use named query

c4ef6c3

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix test

7f574d6

Signed-off-by: SammyOina <sammyoina@gmail.com>

use named params

1a04107

Signed-off-by: SammyOina <sammyoina@gmail.com>

fix typo

93901e1

Signed-off-by: SammyOina <sammyoina@gmail.com>

use inline error checks

08ff60c

remove unrequired conditions Signed-off-by: SammyOina <sammyoina@gmail.com>

sort slices before comparison

6db39e5

Signed-off-by: SammyOina <sammyoina@gmail.com>

rename mainflux_id to thing_id

607ab19

rename MFThing to ThingID rename MFKey to ThingKey rename mainflux_key to thing_key Signed-off-by: SammyOina <sammyoina@gmail.com>

remove mainflux_channels

3170e94

Signed-off-by: SammyOina <sammyoina@gmail.com>

SammyOina force-pushed the view-bootstrap branch from c9ccff2 to 3170e94 Compare July 28, 2023 13:34

simplify unmarshaller

235364e

Signed-off-by: SammyOina <sammyoina@gmail.com>

drasko approved these changes Jul 31, 2023

View reviewed changes

drasko merged commit b7b14cc into absmach:master Jul 31, 2023
1 of 3 checks passed

SammyOina mentioned this pull request Aug 4, 2023

NOISSUE - Update bootstrap examples absmach/magistrala-docs#153

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NOISSUE - Return certs on bootstrap view response #1855

NOISSUE - Return certs on bootstrap view response #1855

SammyOina commented Jul 7, 2023 •

edited

Loading

codecov bot commented Jul 7, 2023 •

edited

Loading

drasko left a comment

dborovcanin left a comment

arvindh123 commented Jul 28, 2023

SammyOina commented Jul 28, 2023

drasko left a comment

NOISSUE - Return certs on bootstrap view response #1855

NOISSUE - Return certs on bootstrap view response #1855

Conversation

SammyOina commented Jul 7, 2023 • edited Loading

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

Notes

codecov bot commented Jul 7, 2023 • edited Loading

Codecov Report

drasko left a comment

Choose a reason for hiding this comment

dborovcanin left a comment

Choose a reason for hiding this comment

arvindh123 commented Jul 28, 2023

SammyOina commented Jul 28, 2023

drasko left a comment

Choose a reason for hiding this comment

SammyOina commented Jul 7, 2023 •

edited

Loading

codecov bot commented Jul 7, 2023 •

edited

Loading