NOISSUE- update health method in SDK #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
approved these changes
Aug 8, 2023
dborovcanin
previously approved these changes
Aug 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #1881 +/- ##
==========================================
- Coverage 67.14% 67.12% -0.02%
==========================================
Files 118 118
Lines 8998 9011 +13
==========================================
+ Hits 6042 6049 +7
- Misses 2327 2333 +6
Partials 629 629
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
drasko
requested changes
Aug 8, 2023
ianmuchyri
force-pushed
the
NOISSUE-updateHealthSDK
branch
from
d200067
to
7e684e6
Compare
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
drasko
force-pushed
the
NOISSUE-updateHealthSDK
branch
from
7e684e6
to
06a3900
Compare
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates the health method in the SDK to facilitate retrieving the health of other services
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
Instead of getting only the health of things service, we can be able to get the health of users, things, bootstrap, certs,reader, and HTTP-adapter services
Have you included tests for your changes?
yes
Did you document any new/modified functionality?
No
Notes