Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MG-2075 - Add guest relation #2228

Conversation

nyagamunene
Copy link
Contributor

@nyagamunene nyagamunene commented May 13, 2024

What type of PR is this?

This is a feature because it adds a policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain

What does this do?

It adds a guest relation policy to a domain member to restrict the creation of new entities such as things, channels and groups in a domain

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

No

Did you document any new/modified feature?

No

Notes

@nyagamunene nyagamunene self-assigned this May 13, 2024
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch 2 times, most recently from ef2287b to 483084a Compare May 15, 2024 14:26
@nyagamunene nyagamunene marked this pull request as ready for review May 15, 2024 15:05
users/service.go Outdated Show resolved Hide resolved
@nyagamunene nyagamunene changed the title MG-2075-Add guest relation MG-2075 - Add guest relation May 21, 2024
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch 3 times, most recently from 185a83d to 25b1b39 Compare May 27, 2024 09:51
arvindh123
arvindh123 previously approved these changes May 28, 2024
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update SDK godocs

users/service.go Outdated Show resolved Hide resolved
auth/service.go Show resolved Hide resolved
rodneyosodo
rodneyosodo previously approved these changes May 29, 2024
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rodneyosodo
rodneyosodo previously approved these changes Jun 5, 2024
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch from 8a5a70a to 6812dc4 Compare June 5, 2024 11:31
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch from 6b5ed62 to 928f55a Compare June 7, 2024 10:27
arvindh123
arvindh123 previously approved these changes Jun 10, 2024
Copy link
Contributor

@arvindh123 arvindh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rodneyosodo
rodneyosodo previously approved these changes Jun 10, 2024
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch from 928f55a to 7306ad4 Compare June 11, 2024 10:16
@rodneyosodo rodneyosodo force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch from 7306ad4 to e66c1d6 Compare June 11, 2024 10:26
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
@nyagamunene nyagamunene dismissed stale reviews from arvindh123 and rodneyosodo via b632af1 June 12, 2024 10:34
@nyagamunene nyagamunene force-pushed the MG-2075-PolicyForDomainMemberToRestrictOnCreationNewEntities branch from e66c1d6 to b632af1 Compare June 12, 2024 10:34
@dborovcanin dborovcanin merged commit 3355332 into absmach:main Jun 12, 2024
6 checks passed
andychao217 pushed a commit to andychao217/magistrala that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants