Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page 49: Need to add Picnic's "plugins.min.css" to Brocfile.js #193

Closed
Oladele opened this issue Apr 1, 2015 · 3 comments
Closed

Page 49: Need to add Picnic's "plugins.min.css" to Brocfile.js #193

Oladele opened this issue Apr 1, 2015 · 3 comments

Comments

@Oladele
Copy link

Oladele commented Apr 1, 2015

Truly, great book so far! Hopefully, this is helpful...

On page 49 (book version downloaded from 3/30/15 email update), I think the following line needs to be added to the Brocfile.js instructions for Picnic css dependency:

app.import('bower_components/picnic/releases/plugins.min.css');

This is needed for the "-header.hbs" <nav> UI element (introduced on page 51) to get its Picnic styling which is not included in the plain picnic.css but is included in Picnic's plugins.css

Oladele added a commit to Oladele/ember-cli-101-errata that referenced this issue Apr 1, 2015
Errata for Issue:" Page 49: Need to add Picnic's "plugins.min.css" to Brocfile.js abuiles#193". abuiles#193
@alexthornton
Copy link

+1

1 similar comment
@jimbeaudoin
Copy link

👍

@abuiles
Copy link
Owner

abuiles commented Apr 23, 2015

Thanks everyone! this will be fixed in today's release :)

@abuiles abuiles closed this as completed Apr 23, 2015
@abuiles abuiles reopened this Apr 23, 2015
@abuiles abuiles closed this as completed Apr 23, 2015
@abuiles abuiles added this to the Release - April 23th, 2015 milestone Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants