Created the resource-router-mapping transform #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcioj
force-pushed
the
convert-resource
branch
from
8b9b8df
to
252011a
Compare
marcioj
changed the title
|
Nice! |
|
@marcioj Thanks! I'll give it a whole review tomorrow morning and release :) |
| } | ||
|
|
||
| function isRoute(route) { | ||
| return route.type === 'ExpressionStatement' && |
There was a problem hiding this comment.
@marcioj can you use recast's API to check the type ?
You can do something like
var types = recast.types.namedTypes;
type. ExpressionStatement.check(route)
type.CallExpression.check(route.expression.callee)
There was a problem hiding this comment.
Good point, I was mixing the two forms. I updated to use the recast namedTypes though
marcioj
force-pushed
the
convert-resource
branch
from
252011a
to
48ceda9
Compare
|
@marcioj thanks! |
abuiles
added a commit
that referenced
this pull request
Jun 30, 2015
Created the resource-router-mapping transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50